Skip to content

Fix orbit values for passive nodes and connection rendering (arcs vs lines)#1998

Merged
LocalIdentity merged 1 commit into
PathOfBuildingCommunity:devfrom
justjuangui:fix/arcandlines
May 29, 2026
Merged

Fix orbit values for passive nodes and connection rendering (arcs vs lines)#1998
LocalIdentity merged 1 commit into
PathOfBuildingCommunity:devfrom
justjuangui:fix/arcandlines

Conversation

@justjuangui

Copy link
Copy Markdown
Contributor

Summary

This PR fixes the orbit values for passive nodes and updates node overlays for
non-mastery nodes. It also corrects how passive tree connections are rendered by
distinguishing between arcs and straight lines based on the connection orbit data.

Background

When building the passive tree from data.json, the orbit value of a connection
determines whether it should be drawn as an arc or a straight line. This
mirrors the behavior found in the PSG file. The same orbit data also affects how
non-mastery node overlays are positioned.

Details

Connection rendering (arcs vs lines)

In the PSG file, a connection orbit can hold one of two values:

  • 0 → the connection is an arc on that orbit
  • 0x7FFFFFFF → the connection is a straight line

The data.json file follows the same pattern, expressed differently:

  • orbit: 0 with orbitX and orbitY → arc
  • orbit: 0 without orbitX and orbitY → straight line

Changes

  • Fix orbit values for passive nodes.
  • Update node overlays for non-mastery nodes.
  • Detect the presence/absence of orbitX and orbitY to determine the
    connection type, and render arcs vs straight lines accordingly.

Validation

Screenshots are attached below for visual verification.

image image image image

@LocalIdentity LocalIdentity added the technical Hidden from release notes label May 29, 2026
@LocalIdentity LocalIdentity merged commit 009a7c5 into PathOfBuildingCommunity:dev May 29, 2026
2 of 3 checks passed
bct8925 pushed a commit to bct8925/PathOfBuilding-PoE2 that referenced this pull request Jun 19, 2026
…astery nodes (PathOfBuildingCommunity#1998)

Co-authored-by: justjuangui <servicios@juacarvajal.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical Hidden from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants